Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Phenogrid MultiCompare results display #656

Closed
glass-ships opened this issue Mar 25, 2024 · 0 comments · Fixed by #725
Closed

Fix Phenogrid MultiCompare results display #656

glass-ships opened this issue Mar 25, 2024 · 0 comments · Fixed by #725
Assignees
@kevinschaper @glass-ships
Labels
bug Something isn't working frontend
Milestone
2024-05 Release

Comments

@glass-ships
Copy link
Collaborator

glass-ships commented Mar 25, 2024 •
edited by vincerubinetti

Something is fishy about multi-compare phenogrid that doesn't quite make sense.

Possibly in the UI component, but I suspect it's possibly an issue with the API method.

See for example the difference between first column in this search in phenotype explorer, vs. this multi-compare call using the same phenotypes from subjects (set A) and column one.
@kevinschaper kevinschaper added this to the 2024-04 Release milestone Apr 2, 2024
@vincerubinetti vincerubinetti mentioned this issue Apr 5, 2024
Closed
@vincerubinetti vincerubinetti reopened this Apr 5, 2024
@glass-ships glass-ships added bug Something isn't working frontend labels Apr 5, 2024
@monicacecilia monicacecilia changed the title Phenogrid MultiCompare not quite working right Fix Phenogrid MultiCompare results display May 15, 2024
@glass-ships glass-ships mentioned this issue May 29, 2024
Merged
3 tasks
glass-ships added a commit that referenced this issue May 31, 2024
@glass-ships @kevinschaper
Fix multi-compare phenogrid (#725)
a9d9d64 
Closes #656 and #697 

- Revert typer from 0.12.3 to 0.7 + typer-cli
- Swap `object_best_matches` for `subject_best_matches` in
`compareSetToSets`
- Add Ancestor IC to cell hover info
- Add `metric` parameter to phenogrid search and multi-compare URLs 
- Link to `phenogrid.md` from `CONTRIBUTING.md`
- [x] Update phenogrid documentation about making iframes a little
- [x] Add test for phenogrid content (@kevinschaper)
- [ ] Change example in phenotype explore / testbed (another PR? this
one?)

---------

Co-authored-by: Kevin Schaper <kevinschaper@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinschaper kevinschaper

@glass-ships glass-ships

Labels
bug Something isn't working frontend
Projects
None yet
Milestone
2024-05 Release
Development

Successfully merging a pull request may close this issue.

Fix multi-compare phenogrid monarch-initiative/monarch-app
3 participants
@kevinschaper @vincerubinetti @glass-ships