Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Allow custom sounds per sender #991

Open
2 tasks done
tmolitor-stud-tu opened this issue Jan 15, 2024 · 4 comments
Open
2 tasks done

[Feature]: Allow custom sounds per sender #991

tmolitor-stud-tu opened this issue Jan 15, 2024 · 4 comments
Assignees
Labels
🎃 GSOC Teaser GSOC teaser task

Comments

@tmolitor-stud-tu
Copy link
Member

Precondition

  • I understood that this template is only for feature requests and not for bug reports

Cross-checked related issues?

Describe your feature

Rewrite the current sound picker using SwiftUI.

The user should be able to pick different sounds for different senders, just like the SwiftUI implementation of the background image allows different images for different senders.

@guodong323
Copy link
Contributor

I am eager to participate in Monal's Google Summer of Code 2024 project this year. To prepare adequately, Could you please assign me to tasks related to the Monal project? I am committed to delivering my best and will adhere to all guidelines and requirements.

@tmolitor-stud-tu
Copy link
Member Author

For all interested in participating in GSOC, I wrote a quick "how to" checklist over at our wiki: https://github.com/monal-im/Monal/wiki/GSOC-2024-Guidline

@guodong323
Copy link
Contributor

MLSoundsTableViewController: Implement the SoundsSettingView.swift using List in SwiftUI.

In ContactDetails.swift, add a new NavigationLink below the Text("Change Chat Background") that includes a Text("Change Chat Sound") and navigates to SoundsSettingView.swift.

Logic section:

In SoundsSettingView.swift, use AVAudioPlayer to play the sound corresponding to the selected index.

When a sound is selected, save the corresponding sound to UserDefaults, and Key is user's contactJid + "AlertSoundFile"

@tmolitor-stud-tu
Copy link
Member Author

tmolitor-stud-tu commented Mar 19, 2024

@guodong323 does closing your PR mean you don't want to work on this anymore or do you want to create a fresh PR instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎃 GSOC Teaser GSOC teaser task
Projects
None yet
Development

No branches or pull requests

2 participants