0.20 based on Bitcoin-core.

[cryptcoin-junkey]

Just I started and not be done. Just working in progress.
I'm trying to apply commits for Monacoin to Bitcoin-core 0.20.

I don't have enough time to do it. But I estimate it can be published until May or June.

I think it's a big news that Monacoin's code base is moved from Litecoin to Bitcoin.
So, at the first, I'll push the 0.20 branch to the forked repository.
After pushed it, I want to discuss the branch can be pushed to the monacoinproject organization.

[cryptcoin-junkey]

I did just apply patches and pushed to https://github.com/cryptcoin-junkey/monacoin-classic/tree/junkey-dev-0.20
Note that I dropped alert and maxfeerate related patches.

I'll make force-push to that branch without notification. Please heads up.

[cryptcoin-junkey]

@wakiyamap Let me make sure.
Where did you get patches for scrypt.cpp ?
It looks they are not from both Monacoin-core and Litecoin-core.

[wakiyamap]

@cryptcoin-junkey from verge.
https://github.com/vergecurrency/verge/blob/master/src/crypto/pow/scrypt.cpp

I've adjusted this.

[cryptcoin-junkey]

What are merits by replacing it ?
I guess there is less performance and/or security effect even if scrypt.cpp was replaced.

[wakiyamap]

openssl is.
Bitcoin is also moving away from using openssl, I think it's better to remove the dependency

[cryptcoin-junkey]

Good point. I agree it's worth to merge.

[cryptcoin-junkey]

Latest WIP 0.19 is here. https://github.com/cryptcoin-junkey/monacoin-classic/tree/4c48619
This have some contributions from @wakiyamap . Some contributions are on hold (some more information required).

[cryptcoin-junkey]

Latest WIP 0.19 is here https://github.com/cryptcoin-junkey/monacoin-classic/tree/89bf75a .

scrypt.c is updated to the Verge's version.
Opt-in RBF is still enabled. It can be enable/disable with no fork if my understanding is not wrong.
So my suggestion is to enable as the preview for now.
After publishing the preview, listening to the user's voice.

[cryptcoin-junkey]

I pushed https://github.com/cryptcoin-junkey/monacoin-classic/tree/junkey-dev-0.19, the final.
I've already moved the branch to 0.20 based and 0.19 is frozen. (Of course, everyone can pull the branch.)
I guess I can push the 0.20 based branch within today.

[wakiyamap]

cryptcoin-junkey@6f795b9#r47370175
Do we need to initialize it with NULL?
I was wrong. sorry.

[cryptcoin-junkey]

No prob. Feel free to comment.

[cryptcoin-junkey]

I pushed the first probably-build-able 0.20 based. https://github.com/cryptcoin-junkey/monacoin-classic/tree/8c9e005

[cryptcoin-junkey]

I pushed the latest build-able 0.20 based. It looks to sync the mainnet. But I've not checked all functionalities.
More Litecoin related commits are reduced (of course, author info of commits are respected as the first priority).
https://github.com/cryptcoin-junkey/monacoin-classic/tree/408dba42b

[cryptcoin-junkey]

I close this because 0.20 based was released.