Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how to load locales with WebPack #269

Closed
mattjohnsonpint opened this issue Feb 24, 2016 · 11 comments
Closed

Clarify how to load locales with WebPack #269

mattjohnsonpint opened this issue Feb 24, 2016 · 11 comments

Comments

@mattjohnsonpint
Copy link
Contributor

Update the Loading locales in the browser section with the info from moment/moment#1435.

Thanks.

@craigstroman
Copy link

Hi,

Is this still open?

If it is I Might be interested in taking it.

Thank you.

@maggiepint
Copy link
Member

I don't think anybody has done it. And we always take documentation improvements, even if something is already covered. Go for it.

@craigstroman
Copy link

Great. This would be my first contribution though.

Should I just clone the repo to work on it?

@maggiepint
Copy link
Member

You're going to want to fork it. Then, clone your fork. You don't have permissions to push to our main repo, but you will be able to push to your fork and then make a pull against our main branch. How you do your git workflow within your fork is up to you, but I personally usually make a branch for each new thing that I do. This way, my fork of master is clean and in line with the main master, not dirtied with commits that may or may not be merged to main.

If you need further help with this let me know.

@craigstroman
Copy link

Ok, thank you for the information.

@craigstroman
Copy link

Hi Maggie,

Sorry for the long delay since yesterday but I do still have a question since I got my local environment set.

I looked through issue 1435 but I don't really see anything talking about loading locale files in the browser.

Could you please point me in the right direction?

@craigstroman
Copy link

Hi,

Does this still need to be done?

@ichernev
Copy link
Contributor

@craigstroman yes, because : moment/moment#3344

@Barkha54
Copy link

Barkha54 commented Oct 8, 2017

Hi, I'm new to open source projects. I tried running the script compile.sh and then started the server using grunt server command. In my command prompt it is showing started connect web server on http //0.0.0.0:6060 but in the browser it is showing page cannot be displayed. Can someone please help me with this?
image

image

@maggiepint
Copy link
Member

maggiepint commented Oct 8, 2017 via email

@Barkha54
Copy link

Barkha54 commented Oct 8, 2017

Thanks a lot. It worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants