Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript definitions for TS>=3.1 are missing in the latest version (v2.25.0) #5491

Closed
hossam-magdy opened this issue May 1, 2020 · 6 comments

Comments

@hossam-magdy
Copy link

hossam-magdy commented May 1, 2020

Describe the bug
Upgrading from 2.24.0 to 2.25.0 results into undefined typings due to introducing typesVersions field in package.json pointing to ts3.1-typings/*: commit: f9e9fe while the dir ts3.1-typings/ is completely missing from the package build 📦 (scripts/npm_prepublish.sh)

To Reproduce
Steps to reproduce the behavior:

  1. npm install moment@2.25.0
  2. import moment from 'moment';
  3. Use the latest TypeScript version, currently 3.8.3 (or any version >=3.1)

Expected behavior
Include ts3.1-typings/ dir in the package build

Screenshots
Screenshot 2020-05-01 at 15 28 48

@hossam-magdy hossam-magdy changed the title TypeScript definitions for TS>=3.1 are missing from the package TypeScript definitions for TS>=3.1 are missing in the latest version (v2.5.0) May 1, 2020
@rvanlaarhoven
Copy link

I think you're referring to the incorrect version numbers. 2.25.0 introduced the issue. Downgrading to 2.24.0 is a workaround for now.

@rvanlaarhoven
Copy link

Duplicate of #5486 by the way.

@hossam-magdy hossam-magdy changed the title TypeScript definitions for TS>=3.1 are missing in the latest version (v2.5.0) TypeScript definitions for TS>=3.1 are missing in the latest version (v2.25.0) May 1, 2020
@hossam-magdy
Copy link
Author

UPDATE:
This commit 6e32433 is supposed to fix the issue, but it is not yet released... looking forward to version >= 2.25.1!

@ichernev
Copy link
Contributor

ichernev commented May 1, 2020

2.25.1 released.

@ichernev ichernev closed this as completed May 1, 2020
@reidperyam
Copy link

reidperyam commented May 1, 2020

errors remain with 2.25.1 installed

@Blackbaud-RakeshGarg
Copy link

errors remain even 2.25.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants