New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sk.js
: Fix l10n issues (czechisms)
#5408
Comments
sk.js
: Replace za %s
with o %s
sk.js
: Fix l10n issues (czechisms)
@k2s thoughts? |
|
@k2s, although my statement in the OP is not entirely correct, it is partially correct. As the current implementation of the issue in Moment. And as the implementation is not entirely corrent, I think it should be fixed. I have no idea how, but IMHO the output should be always correct. Your proposed solution ( Based on the sources from your comment in #5409 (which are indeed valid) I have wrote the following in a comment:
Therefore, the current output not correct for |
@tukusejssirs thank you that you try to implement and improve support for slovak language in libraries. in relation to moment library, you need to keep in mind that it is established library, used by many projects and to change something has most of all not break existing code. name of this ticket says that the returned to correctly return I understand your desire to have it perfect and the way to achieve it is to create moment plugin which will provide methods with context support. |
Well, I tried to pass the same: #5206, which was reverted afterwards :-( |
@dakujem, thanks for your comment. It makes me feel I’m not alone in this. 😄 When I created this PR, I thought we should always use Therefore from my current point of view, if we use either |
Indeed, both are used. I would bet that Unfortunatelly, I'm not a JS guy 🤷, my JS plugin would be bad 😆 |
@dakujem, currently we don’t need the code, but the algorithm—how to check what preposition Moment should output? |
I don't know how we can distinguish between points in time and periods of time. The locales can always be overridden by individual users. |
That’s a great pity. |
Hm... Perhaps we can distinguish usage between durations and moments. I will leave it open for a little while longer. |
It sounds good me. Is there any way we could get this ‘metadata’ now? Or is it something you need to implement into Moment? |
I don't know what you mean. for now: |
On a second thought, this won’t solve this issue, because If you still think it’ll solve this issue, please share with me some code snippets how I could distinguish between the two. Thanks. |
I read through this discussion again. It sounds like the difference between It seems like the best strategy is to use one, and replace it outside of Moment.js when you need. If you have other ideas, feel free to re-open. Best of luck! |
@marwahaha, that was my impression, too. It is a pity, but it is true. It’s shame that most l10n tools are so English-concerned that they can’t be modified to fully support other locales. I wish Moment would be like Fluent. Until then, I think that this is a dead end. |
Describe the bug
The preposition
za
in the sense ofin
inin a minute
is a czechism (a word or usage borrowed from the Czech language), therefore themoment
’sza pár sekúnd
is correct in Czech, and incorrect in Slovak. In Slovak, the correct preposition iso
in the phrase.Expected behavior
For example: use
o pár second
instead ofza pár sekúnd
(meaning:in a few seconds
).Update: Another issue is theNot an issue ofpred 3 dny
which should bepred 3 dňami
.moment
, but ofdayjs
, my bad.The text was updated successfully, but these errors were encountered: