Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in locale "tr", "Do" format is not working #5039

Closed
dogukankotan opened this issue Mar 14, 2019 · 3 comments
Closed

in locale "tr", "Do" format is not working #5039

dogukankotan opened this issue Mar 14, 2019 · 3 comments

Comments

@dogukankotan
Copy link

Describe the bug
in locale "tr", "Do" format is not working. Need to test all formats again.
To Reproduce
Steps to reproduce the behavior:
-> moment().locale('tr').format('Do')

Expected behavior
It should return suffixes. Ex: for value 15 -> "15inci"

Screenshots

  • no

Desktop (please complete the following information):

  • Browser: any browser

Smartphone (please complete the following information):

  • Browser: any browser

Moment-specific environment

  • The time zone setting of the machine the code is running on
  • The time and date at which the code was run
  • Other libraries in use (TypeScript, Immutable.js, etc)

Please run the following code in your environment and include the output:

console.log((new Date()).toString())
console.log((new Date()).toLocaleString())
console.log((new Date()).getTimezoneOffset())
console.log(navigator.userAgent)
console.log(moment.version)
Thu Mar 14 2019 10:12:15 GMT+0300 (GMT+03:00) debugger eval code:1:1
3/14/2019, 10:12:15 AM debugger eval code:2:1
-180 debugger eval code:3:1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:65.0) Gecko/20100101 Firefox/65.0 debugger eval code:4:1
2.24.0
@LukaszGrela
Copy link

I think this line should not be there then (or moved before default: line) where suffixes are added.

@Hiba-moh
Copy link

I would like to work on this, if that's Ok

@marwahaha
Copy link
Member

Thanks for this request.

Ordinals used to be there. They were asked to be removed in #4122 (comment) (that is the locale author) so I am not sure we should add them back. I will close this issue unless there is a strong case to re-open (government source, cldr, or similar)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants