2.19.1: can no longer combine moment, moment-timezone and moment-business-days

[jkudish]

I used to be able to combine moment, moment-timezone, moment-business-days (and moment-range but that one isn't a problem in this situation), like so:

import 'moment-timezone';
import moment from 'moment-business-days';
import { extendMoment } from 'moment-range';

moment.locale('en-us', {
    week: {
        dow: 1, // Monday is the first day of the week
    },
    holidays: [
        '2017-10-09',
        '2017-12-25',
        '2018-01-01',
        '2018-04-02',
        '2018-05-21',
        '2018-06-25',
        '2018-07-02',
        '2018-09-03',
        '2018-10-08',
        '2018-12-24',
        '2018-12-25',
    ],
    holidayFormat: 'YYYY-MM-DD',
});

moment.tz.setDefault('America/Montreal');

export default extendMoment(moment);

This worked in all versions before upgrading to 2.19.1. Now I get the following error:

Uncaught TypeError: Cannot read property 'setDefault' of undefined

And i traced it down to moment.tz no longer getting defined.

The problem is if I import moment from moment-timezone then moment-business-days will no longer work.

Environment:

Chrome 61 on MacOS 10.12.6
Compiled with webpack

debug output:

Thu Oct 12 2017 12:29:48 GMT-0700 (PDT)
10/12/2017, 12:29:48 PM
420
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36
2.19.1

Any ideas?

[gtwilliams03]

I believe I am getting something similar.

Using import moment from 'moment-timezone' on this line:

var deadlineDisplay = moment.duration(deadlineSeconds, "seconds").format("h [hrs], m [min], s [sec]”)

Throws this error:

Uncaught TypeError: _momentTimezone2.default.duration(...).format is not a function

Rolling back to 2.18.1 it works fine.

[boblauer]

I'm seeing a similar error. moment-timezone should just be adding new methods to moment, and then returning the original moment object. However, something in 2.19.1 is causing moment-timezone to return a completely different instance than moment.

require('moment').version // 2.18.1
require('moment') === require('moment-timezone') // true

require('moment').version // 2.19.1
require('moment') === require('moment-timezone') //false

[nadeemja]

Same for both 2.19.0 and 2.19.1

[ValeryG]

is it going to be fixed any time soon? or is there a known work around for this? staying on 2.18.1 might not be an option much longer...

[dfischer0]

Are you sure this issue still exists with Moment 2.24.0 & moment-timezone 0.5.26? If I do:

require('moment-timezone');
var moment = require('moment-business-days');

I don't seem to have a problem using moment.tz

[marwahaha]

Please re-open if you still have issues.

[gongAll]

This is still an issue, tho.

require('moment').version // 2.24.0
require('moment') === require('moment-timezone') // true

require('moment').version // 2.25.3
require('moment') === require('moment-timezone') // false

require('moment').version // 2.26.0
require('moment') === require('moment-timezone') // false

require('moment').version // 2.27.0
require('moment') === require('moment-timezone') // false

So since version 2.24.0 I cannot set timezones. This is a real bummer.