Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of invalid string changed to valid from 2.9.0 to 2.12.0 #3094

Closed
Aukhan opened this issue Apr 6, 2016 · 2 comments
Closed

Parsing of invalid string changed to valid from 2.9.0 to 2.12.0 #3094

Aukhan opened this issue Apr 6, 2016 · 2 comments

Comments

@Aukhan
Copy link

Aukhan commented Apr 6, 2016

Hi Guys,
Not sure if this is an issue or an enhancement made during the course of things,
somehow we were stuck on 2.9 and updated to 2.12 recently

earlier(2.9) we would parse things like moment("2016-04-06Tnull").isValid() // gives false
but now(2.12) this kind of parsing returns true with the time set to 00:00:00

Mostly just sharing my experience after the upgrade.

Great work by all of you !

@maggiepint
Copy link
Member

If it's okay with you, I'm going to call this the same as #2985 and close this.

I know it doesn't look exactly the same, but I believe it's basically the same issue.
Thanks for letting us know.

@Aukhan
Copy link
Author

Aukhan commented Apr 7, 2016

@maggiepint thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants