Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.0 Changelog #288

Closed
timrwood opened this issue Apr 26, 2012 · 11 comments
Closed

1.7.0 Changelog #288

timrwood opened this issue Apr 26, 2012 · 11 comments

Comments

@timrwood
Copy link
Member

New features

Bugfixes

Language updates

@rockymeza
Copy link
Contributor

@timrwood, do you think that instance language configuration will get into 1.7.0?

What is left to be done other than that for us to push this out?

@timrwood
Copy link
Member Author

I updated the list above. I think this is pretty good for the 1.7.0 release, what do you think?

@rockymeza
Copy link
Contributor

I think that is a solid release. When do you think we should shoot for as a launch date? I have a couple of questions regarding the status of some of these changes:

  1. Do you think Persian will get put into this release? It doesn't actually have tests or a real pull request.
  2. Have the Russian changes been made yet? We need the Russian changes in order to be sure that Add support for month/weekday callbacks in moment.fn.format #313 works, but we also need Add support for month/weekday callbacks in moment.fn.format #313 in order to make the Russian changes. Do the developers that speak Russian know that they can base their work on the feature/add-month-name-callback branch?
  3. Did you decide what to do for Add singular/plural forms for durations and startOf/endOf? #296?

@timrwood
Copy link
Member Author

  1. Yeah, a pull request with tests should be mandatory for adding a language. Same with Romanian localization #326.
  2. I commented that they can use that branch, and bumped the thread. Let's give it a couple days, but I don't want to hold up the 1.7.0 release for it. If we don't hear anything, then I don't think we should land Add support for month/weekday callbacks in moment.fn.format #313.
  3. Added a comment on Add singular/plural forms for durations and startOf/endOf? #296. I'll add the code.

Let's shoot for releasing on Thursday or Friday? Any lang changes that miss the boat can go out in 1.7.1 bugfix release a week or two after.

@rockymeza
Copy link
Contributor

I should have the loadLang code down by then too.

@timrwood
Copy link
Member Author

Looks like #313 solves #325 as well, so I'm just going to pull it in. I'll write a dummy lang config like this for testing so we dont have to rely on lang configs to test core functionality. Probably should do that for all the other lang config callbacks as well.

@timrwood
Copy link
Member Author

I think this is ready to go, @rockymeza do you mind taking a look at the docs on https://github.com/timrwood/momentjs.com/tree/develop ?

I added docs for everything in the new features, but it's good to have a second pair of eyes...

Then hopefully we can cut a release today! Finally!

@rockymeza
Copy link
Contributor

I commented on one thing, but other than that I think the docs you added look good.

@timrwood
Copy link
Member Author

This is released!

@mirontoli
Copy link
Contributor

To Language updates belongs "Add Chuvash Language" as well. I am happy about that.

@timrwood
Copy link
Member Author

@mirontoli, updated!

@timrwood timrwood closed this as completed Aug 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants