Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deepkit #894

Open
BasixKOR opened this issue Jun 17, 2022 · 5 comments
Open

Add deepkit #894

BasixKOR opened this issue Jun 17, 2022 · 5 comments

Comments

@BasixKOR
Copy link

As a part of the Deepkit framework they provide a runtime type implementation documented here: https://deepkit.io/documentation/type

@moltar
Copy link
Owner

moltar commented Jun 17, 2022

Thanks for the tip @BasixKOR!

We have benchmarks for @marcj/marshal (which is from the same author as Deepkit).

The link to @marcj/marshal repo seems to redirect to Deepkit now too.

Wondering if it is now part of the project or is it a separate project?

@marcj could you please add your thoughts. Thanks!

@marcj
Copy link
Contributor

marcj commented Jun 17, 2022

Marshal was the foundation of Deepkit, so the repo was renamed. Its functionality with the same JIT technique is now in deepkit/type, but instead of being based on classes with TypeScript decorators, it's now based on runtime TypeScript types. The refactor is relatively new, so I expect a slight decrease in performance.

@moltar
Copy link
Owner

moltar commented Jun 17, 2022

Sounds like we probably want to keep both @marcj/marshal and deepkit for now?

@BasixKOR would you be able to contribute a PR for this?

@BasixKOR
Copy link
Author

BasixKOR commented Jun 17, 2022

I'm definitely interested, but I wasn't sure where should I put @deepkit/type-compiler for benchmarking (more specifically whether does it impact other benchmarks)

@moltar
Copy link
Owner

moltar commented Jun 17, 2022

@hoeck is the Chief Classifier in this repo, maybe he can pitch in with his thoughts? 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants