Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel benchmarking #823

Open
moltar opened this issue Jan 18, 2022 · 0 comments
Open

Parallel benchmarking #823

moltar opened this issue Jan 18, 2022 · 0 comments
Labels

Comments

@moltar
Copy link
Owner

moltar commented Jan 18, 2022

Parallelization had to be disabled a while ago, because the final step of the benchmarking run (per Node version) is to commit back the results. This resulted in a race condition, between runs and some would fail to commit, as they had a stale git checkout.

I think we can fix this by running the benchmarks in parallel, but instead of committing the results right away, use GitHub actions artifacts mechanism to store the results in the cache.

Then as the last step, get the cached results at once, and commit them at once.

@moltar moltar added the ci label Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant