Light type #1033
Light type #1033
Conversation
|
Please also add the package to the |
|
Lots of this. I think it is due to the older TS version. :/ |
Right I see now this repo is on 4.6, yeah I might be using some newer features. Is it okay to upgrade typescript in this repo or you're keen to keep it lower for compat reasons? |
|
Doesn't look like updating TS will be easy in this repo, GTS is already complaining that it only supports up to 4.5.0, while not having a newer release, and running the lint command seems to build the libs and then results in prettier errors for the build folders. Needs some work to replace gts and ignore linting the build dirs. |
Yeah, upgrading is easy, just there are some other packages that break then 😁 Need to decide if we shall be deprecating those packages eventually. @hoeck thoughts? |
|
In theory I should be able to do some type lowering for light-type, just need to find the time. Though I'm seeing plenty of libraries now requiring 4.7 as a baseline - I guess your own hand might get forced upward in that respect |
Yeah, I have nothing against the new features, and in fact, always use latest TS on all my projects. It is just a decision we have to make, or a complete architecture, which is also probably something would be good, to isolate each package's test environment entirely. |
Same here 👍
Keeping lots of different TS versions around and separating them from one another looks like a lot of work to me without much gain. Performance is not very likely to be affected by different TS versions at all. And even if this were the case, would anyone choose a package because it is more performant in an older version of TS?
Removing (or disabling) old unmaintained packages seems like a good tradeoff for me. I'd say lets go check what happens if we bump TS to the latest version 😁 |
|
@Nick-Lucas typescript is at |
Closes #1032