-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How do I add a testcase (Request: Documentation on that) #1012
Comments
@hoeck Do you have any input on this? |
@jeengbe have you tried running the tests with If a benchmarked library does not implement the benchmark correctly (e.g. raises an exception if the data is valid) the benchmark will crash. The tests are meant to ensure that the benchmarked libraries do indeed conform to the benchmark spec. |
Ah yes, I could debug it with jest. Along the lines of parseSafe:
assertStrict
|
👍 also at the bottom of the benchmark graph there is a short description what every benchmark is supposed to test: https://moltar.github.io/typescript-runtime-type-benchmarks/ |
I didn't expect so much feedback and new libraries so you're right, documentation is missing a bit. If you could add a few hints / bullets to the readme on how to add a new library, that would be great. Feel free to ask when something is not working or if you need some help. |
throws an exception on invalid which crashes the process.
The text was updated successfully, but these errors were encountered: