-
-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis discoverer implements scan incorrectly for Cluster configurations #938
Comments
Thanks. |
Could you create a PR? |
Now I will make and add tests |
The preliminary result is that simply sending the request through master will not work. I'm figuring out if this problem is related to my tests or it's a bug in ioredis |
I am testing on 2 different cluster configurations and am getting 2 completely different problems. |
I've since moved to use etcd for service-discovery. Both redis-cluster and redis-sentinel were deployed in a k8s cluster using bitnami helm charts. What problems specifically are you encountering? |
Sentinel works differently, unlike redisCluster, a similar problem does not occur there. With redisCluster, additional commands are sent to redis-server which results in an error.
|
Any news about it? |
Alas, I don't have a solution yet. In testing, I didn't a solution with |
moleculer/src/registry/discoverers/redis.js
Line 375 in 6f6225d
this.client.scanStream
is used in multiple locations through the custom redis discoverer.scanStream
does not exist onclient
forRedis.Cluster
. I believe must iterate overclient.nodes('master')
to perform a scan, similar to how the Redis' cacher is written.The text was updated successfully, but these errors were encountered: