Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include fonts in inst/ #1

Closed
seasmith opened this issue Mar 28, 2019 · 4 comments
Closed

Include fonts in inst/ #1

seasmith opened this issue Mar 28, 2019 · 4 comments

Comments

@seasmith
Copy link

Including the fonts in inst/ would make these fonts accessible to R code via system.file() -- allowing them to be be registered and loaded via extrafont within the vapoRwave package.

The DESCRIPTION file would need to reflect the font authors, copyright holders, etc. Most of the fonts seem to not have any license restrictions prohibiting this kind of distribution.

@moldach
Copy link
Owner

moldach commented Mar 31, 2019

Thank you for the useful issue @seasmith I'll be sure to address this.

@moldach moldach pinned this issue Mar 31, 2019
@mrbuche
Copy link

mrbuche commented Aug 11, 2022

I'm also having some trouble getting the fonts to work, even when doing this. Has anyone had any luck? Could we make a Docker image?

@moldach
Copy link
Owner

moldach commented Nov 23, 2023

Hello @mrbuche,

Apologies for the delayed response, and thank you for your patience 😊 Could you please specify the operating system you are using?

I've implemented a zzz.R file that streamlines font installation for Ubuntu users. For Windows users, I've documented additional manual steps in the README. Please note that the MacOS compatibility is yet to be tested 🚀

I appreciate your suggestion, and I'm considering creating a Docker image in the near future to enhance accessibility. Your feedback is valuable, and I'm committed to improving the user experience ♿

Thank you again for bringing this to my attention @seasmith ❤️

@mrbuche
Copy link

mrbuche commented Nov 24, 2023

@moldach thank you so much for your response!

I was using WSL in Windows but since then I have an actual Ubuntu OS. Tried it today, works great! I bet the extra stuff you added lately works for Windows.

@moldach moldach closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants