Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get independent of Gblocks #49

Open
iimog opened this issue Sep 15, 2023 · 2 comments
Open

Get independent of Gblocks #49

iimog opened this issue Sep 15, 2023 · 2 comments

Comments

@iimog
Copy link
Member

iimog commented Sep 15, 2023

We use Gblocks to filter the alignments in this line:

$cmd = $self->{'gblocks-bin'}." $out/$gene.aln -t=p -b4=4 -b5=h";

So we are keeping blocks of length at least 4 with at least half the positions being non-gaps (see Gblocks documentation). This task can probably be performed by a simple script that we could include in the distribution. Gblocks is quite dated and a dependency that users need to get and install themselves. Therefore, getting rid of this requirement would be nice.

@jianshu93
Copy link

Hello @iimog,

Since you also mentioned this, trimAl is more updated and can be used for any modern CPUs (even M1/2/3 series by Apple). Check it here: https://github.com/inab/trimal

I think get rid of Gblocks is important because it is not supported by new CPUs like M series. Should be easy work (several lines of modification I presume).

Thanks,

Jianshu

@iimog
Copy link
Member Author

iimog commented Jan 3, 2024

Cool, thanks for the suggestion. I have not used trimal before, but it looks almost like a drop-in replacement. However, it still probably needs some testing, whether results are similar to those with Gblocks. What do you think @chiras ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants