Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current muscle (5) is not compatible #48

Open
peterthorpe5 opened this issue Sep 7, 2023 · 4 comments
Open

current muscle (5) is not compatible #48

peterthorpe5 opened this issue Sep 7, 2023 · 4 comments

Comments

@peterthorpe5
Copy link

Dear IImog,

Thank you for the tool - Love it!! Just a heads up the current version of bcgTree does not play well with muscle (5) - current version . The error is:

..../bin/muscle -in gene_tree_120_conserved/TIGR00061.fa -out gene_tree_120_conserved/TIGR00061.aln

Invalid command line
Unknown option in

[09-07 11:29:47] [bcgTree]
[09-07 11:29:47] [bcgTree] ERROR: muscle on TIGR00061 failed

Solution: Downgrade to muscle 3.8

Pete

@iimog
Copy link
Member

iimog commented Sep 14, 2023

Hi Pete,
thanks a lot for raising this issue. I'll try to find a way to make bcgTree compatible with old and new versions of muscle. But for now I leave this issue open as information to other users.
Best,
Markus

@iimog
Copy link
Member

iimog commented Sep 14, 2023

Making bcgTree work with muscle 5 might be as easy as changing in to align in this line:

my $cmd = $self->{'muscle-bin'}." -in $out/$gene.fa -out $out/$gene.aln";

This would break compatibility with older muscle versions, though. I also need to do some testing that there are no other relevant changes between muscle versions, e.g. in the output format.

@peterthorpe5
Copy link
Author

It would break backwards compatibility. Can you extract the version for the -v and apply the command accordingly?

@chiras
Copy link
Collaborator

chiras commented Sep 14, 2023

Thanks for raising this, and yes it should be addressed. Thanks @iimog for taking care.

Once this is done, please also update the README, I have a while back made there a comment that only 3.8 is supported for now and posted a link to that binary:

dceaf223a92679e399aab367ca3ef29f618d94b7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants