Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable therubyracer gem #14

Open
ohookins opened this issue Oct 15, 2013 · 4 comments
Open

Enable therubyracer gem #14

ohookins opened this issue Oct 15, 2013 · 4 comments

Comments

@ohookins
Copy link
Contributor

What do you think of uncommenting the line that installs therubyracer? On my Vagrant test machine at least I couldn't progress with running the app before installing this gem.

@ohookins
Copy link
Contributor Author

@PragTob

@ghost ghost assigned PragTob Oct 15, 2013
@PragTob
Copy link
Collaborator

PragTob commented Oct 15, 2013

I'm not quite sure, I think we should be good with execjs if I remember correctly it checks whether you got a runtime env installed (like node) and if not install therubyracer or something.

Dunno why/when the thrubyracer was commented out.

@ohookins
Copy link
Contributor Author

For me it failed hard, suggesting I check out the URL in the Gemfile but didn't install any JS runtime.

@PragTob
Copy link
Collaborator

PragTob commented Oct 15, 2013

Okay so I believe therubyracer can't be in there due to heroku. So we could put it under development. A quick survey (well between me and a friend) showed that mostly you should probably use node e.g. sudo apt-get install node.

I don't know what execjs will do if it finds both. It'll probably choose node. So yeah we should have installing node in the README or therubyracer in development (and maybe test) environments. Probably both. Not too familiar if anything has changed in 4.0 about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants