Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno support for mojo.js #68

Open
recrof opened this issue Jun 22, 2022 · 6 comments
Open

Deno support for mojo.js #68

recrof opened this issue Jun 22, 2022 · 6 comments
Labels
enhancement New feature or request needs feedback

Comments

@recrof
Copy link

recrof commented Jun 22, 2022

As both mojo.js and Deno are young projects that have great potential and are (imo) great match, would it be possible to port mojo.js to Deno ecosystem?

@kraih
Copy link
Member

kraih commented Jun 22, 2022

We would have to get rid of a few more dependencies, but yes, i think it is quite possible.

@kraih kraih added enhancement New feature or request needs feedback labels Jun 22, 2022
@recrof
Copy link
Author

recrof commented Jun 22, 2022

We would have to get rid of a few more dependencies, but yes, i think it is quite possible.

Deno includes some of the browser APIs that are not present on node.js, which could help remove few of the dependencies. As I'm from perl background and use mojo utils already(and I'm not mistaken that mojo.js also uses this) Mojo::DOM can use https://deno.land/x/deno_dom@v0.1.31-alpha/deno-dom-wasm.ts which is much closer to native DOMParser present in web browsers.

@kraih
Copy link
Member

kraih commented Jun 22, 2022

The DOM parser we already use probably works fine on Deno. HTTP and WebSocket bindings should be fairly easy too. And i'd like to have our own replacements for tough-cookie, form-data and busboy at some point anyway. Those three probably represent most of the real work required.

@kraih
Copy link
Member

kraih commented Jul 6, 2022

And now there is also Bun, which actually looks even better than Deno.

@ralyodio
Copy link

ralyodio commented Oct 3, 2022

+1 for Bun. It looks awesome.

@shah
Copy link

shah commented Nov 19, 2022

Deno 1.28 now supports NPM modules natively so it's worth checking out if mojo.js will now work "out of the box".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs feedback
Projects
None yet
Development

No branches or pull requests

4 participants