feat: replaced notification component with UI library's #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Crystalsage PTAL? |
Crystalsage
approved these changes
Dec 4, 2022
There was a problem hiding this comment.
LGTM. Thanks for working on this @thisiskaransgit.
@chicken-biryani
Janvi-Thakkar
approved these changes
Dec 26, 2022
|
@thisiskaransgit, Can you please resolve the conflicts so that we can merge it? |
|
Hey @Janvi-Thakkar, I had to revert the changes to resolve the conflicts, I've made a fresh PR, please take a look at #443, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karan Singh Thakur karanthakur.work@gmail.com
Description
This PR fixes #394
Replaced all of the Notification component instances in DatePickerPoint.vue with UI-library's Notifications component
Additional Context (Please include any Screenshots/gifs if relevant)