Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Replace current Notifications component with UI-library's Notifications component - DatePickerPoint #394

Open
Crystalsage opened this issue Sep 16, 2022 · 8 comments

Comments

@Crystalsage
Copy link
Contributor

Crystalsage commented Sep 16, 2022

Describe the solution you'd like.

Replace all of the Notification component instances in DatePickerPoint.vue only.

Additional context.

The current Notification component can be found at: https://flint-ui.vercel.app/flint/configurations/point and other places throughout the project.

For Point simulation - run the simulation. A success notification should pop up.

image

Current notification component reference: https://www.antdv.com/components/notification
UI-library notification reference link: https://moja-global-ui-library.vercel.app/?path=/story/components-alert--solid-success
npm-package of UI-Library: https://www.npmjs.com/package/@moja-global/mojaglobal-ui

@Crystalsage Crystalsage added the enhancement New feature or request label Sep 16, 2022
@thisiskaransgit
Copy link
Contributor

I'd like to work on this issue

@shloka-gupta shloka-gupta changed the title [OSD] Feature Request: Replace current Notifications component with UI-library's Notifications component - DatePickerPoint Feature Request: Replace current Notifications component with UI-library's Notifications component - DatePickerPoint Nov 22, 2022
@shloka-gupta
Copy link
Member

Hey, @thisiskaransgit I know that it is WAAAY past October.... But would you still like to work on this?

@thisiskaransgit
Copy link
Contributor

Yup, I'll start working on it asap 😄

@github-actions
Copy link

This issue has not seen any activity for the past 30 days. If this Issue would not see any further updates in the next 7 days, it would be automatically closed. Please comment on the issue if you would like to discuss on this further.

@abhilipsasahoo03
Copy link
Contributor

Hi @chicken-biryani if this issue is not being worked upon currently, can I take it up?

@thisiskaransgit
Copy link
Contributor

Oh hey @abhilipsasahoo03, I've already worked on this PR and it has been merged, this issue is just waiting it be closed,
btw this issue is still open and no one is working on it, you can take a look at it.

@abhilipsasahoo03
Copy link
Contributor

Oh hey @abhilipsasahoo03, I've already worked on this PR and it has been merged, this issue is just waiting it be closed,
btw this issue is still open and no one is working on it, you can take a look at it.

Thanks for informing! :) @thisiskaransgit

@github-actions
Copy link

This issue has not seen any activity for the past 30 days. If this Issue would not see any further updates in the next 7 days, it would be automatically closed. Please comment on the issue if you would like to discuss on this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants