Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block_from_labels probably breaks with columns that need quoting #2028

Open
ADBond opened this issue Mar 5, 2024 · 0 comments
Open

block_from_labels probably breaks with columns that need quoting #2028

ADBond opened this issue Mar 5, 2024 · 0 comments
Labels
blocking bug Something isn't working needs investigation

Comments

@ADBond
Copy link
Contributor

ADBond commented Mar 5, 2024

I haven't checked, but I think linker.block_from_labels will probably break if the user has a unique_id (or source_dataset) column that needs quoting, such as with spaces: 'unique id'.

See the relevent code

Think we should be handling that with InputColumn
@ADBond ADBond added bug Something isn't working needs investigation blocking labels Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocking bug Something isn't working needs investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ADBond