Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spam score missing in column picker on Thunderbird 115 #35

Open
lo92fr opened this issue Dec 4, 2023 · 9 comments
Open

Spam score missing in column picker on Thunderbird 115 #35

lo92fr opened this issue Dec 4, 2023 · 9 comments

Comments

@lo92fr
Copy link

lo92fr commented Dec 4, 2023

Hello,

First, thanks a lot for this very good extension.
I have an issue on my current setup : Thunderbird 115 / Windows.
When I want to enable the "Spam score" column, I can't find it in the column picker.
All the other functions is working great.
Let me know if I can check something on my side.

Thunderbird rspamd

Best regars,
Laurent.

@moisseev
Copy link
Owner

moisseev commented Dec 4, 2023

Unfortunately the score column feature is not supported on Thunderbird Supernova for now.

Blocked by bug 1817682

image

@lo92fr
Copy link
Author

lo92fr commented Dec 4, 2023

Hello,

Thanks for your quick answer.
I haven't notice the warning message in the options :(.

Laurent.

@realizelol
Copy link

If I understand them correctly there are some interesting news @ https://bugzilla.mozilla.org/show_bug.cgi?id=1817682
As this bug was closed 2 days ago.

It just looks like that the sorting of this column is actually still buggy, but I think that is not the main focus:
https://bugzilla.mozilla.org/show_bug.cgi?id=1877390

Hope to hear sth. new soon.

@realizelol
Copy link

Even bug https://bugzilla.mozilla.org/show_bug.cgi?id=1817682 has been closed 3 month ago. There are a lot more detailed threads which are also for the new released TB 115.10.

I'm no developer but this patch looks promising:
https://hg.mozilla.org/releases/comm-esr115/rev/6051d34851df

@moisseev
Copy link
Owner

Is it stable? I'll wait at least until it is announced and API is documented.

@adlerweb
Copy link

As some Add-ins started adopting the new API, I made a crude attempt at copying their code. Spaminess-Column can be displayed and score is shown. Icons are still broken, also settings ui won't open, so consider the code only as a test.
Test XPI can be found at https://github.com/adlerweb/rspamd-spamness/releases/tag/supernova-1 - use at your own risk…

@moisseev
Copy link
Owner

@adlerweb,

Icons are still broken

adlerweb@ed2dece#diff-acd17dc167bd3f7e293448db0145cd6d504fa5247e526f59815b6278ac3debeeR51

As far as I can see, your iconCallback returns an icon URL, but it should return an id of the icon, which should be defined in the iconCellDefinitions.

https://github.com/mozilla/releases-comm-central/blob/a0082c2ba398172eafed1cc03e0c4fda5d4bcaa4/mail/base/content/modules/ThreadPaneColumns.mjs#L404-L479

@realizelol
Copy link

@adlerweb is it possible that moisseev adapt your code or to create a pull request where the maintainer is allowed to change the code?

Also in the german translation I wouldn't call the score Punkte something like Wertung or Spamwert is more clarified.
Punkte sounds like dots and not a value. How do you think about that? I personally would recommend Spamwert.
The same meaning also appears in different spelling Punkte, Spam-Wahrscheinlichkeit, SPAM-Punkte, 'Spam Punkte', 'SPAM-Punkte [Rspamd]' maybe that should also point to one spelling.

Thank you very much for your work that looks very promising to have the score column working again soon.

@moisseev
Copy link
Owner

Regarding the PR suggested by @realizelol , I am currently working on implementing columns properly, so there's no need to duplicate efforts.

moisseev added a commit that referenced this issue May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants