Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickinstall.py and "m" need to die #1621

Open
ThomasWaldmann opened this issue Feb 23, 2024 · 3 comments
Open

quickinstall.py and "m" need to die #1621

ThomasWaldmann opened this issue Feb 23, 2024 · 3 comments
Labels

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Feb 23, 2024

These are nice convenience wrappers for developers and "git checkout users", but for a normal installation (like after pip install or after installing a moin linux dist package) I guess they won't work.

Also, these are VERY special to moin and feel alien even to users familiar with the usual python software installation / usage workflows.

These 2 scripts do all sorts of stuff and depending on the target user group I think we need different ways to replace these scripts:

  • For the developer-only oriented helpers, I guess we could use tox or even make. For another project I just created a scripts/make.py to do misc. stuff there (including a clean subcommand, replacing python setup.py clean). No stuff that a end users needs should be in there.
  • For the moin admins / "users", I think we either should integrate into a moin (or moin-admin) script command (these will be provided by pip install and also by a linux dist package install).
  • Everything dealing with virtual envs should be removed from our helpers (like creating venvs or running commands from a venv's bin directory). That is outside of the scope that moin tools should cover and there are good tools for that, like e.g. pipx, or just the basic python -m venv python users are very familiar with. Pycharm, for example, also supports devs creating and activating venvs and trying to do that again in moin might rather collide with such stuff.
  • Guess it is easier for new users to run 2 or 3 python-related commands they are familiar with than learning 1 new moin-special wrapper command.
@ReimarBauer
Copy link
Member

When there is a pypi package we can use grayskull to create a conda-forge package. I also added there some of the xstatic packages already.

@RogerHaase
Copy link
Member

dup of #1419 and #824?

@sfermigier
Copy link

Yes. I think once the virtualenv is set up (and there are tools for that: poetry, pdm/hatch, rye...), administrative commands should be available via subcommands of the flask CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants