Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug report - XSS #30

Open
guillaC opened this issue Sep 15, 2020 · 1 comment
Open

bug report - XSS #30

guillaC opened this issue Sep 15, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@guillaC
Copy link

guillaC commented Sep 15, 2020

you should use a richtextbox rather than a webviewer
more information about XSS: https://en.wikipedia.org/wiki/Cross-site_scripting

payload:
![a](javascript:alert("hey"))

screenshot:
image

@mohzy83 mohzy83 added the enhancement New feature or request label Oct 16, 2020
@mohzy83
Copy link
Owner

mohzy83 commented Oct 16, 2020

The idea is to use a real html-renderer with full css/font support.
The most .NET HTML-rendering engines are very limited in terms of styling.
You can try the plugin MarkdownViewer++ https://github.com/nea/MarkdownViewerPlusPlus , which is using some kind richtext component to render the HTML.
I think for the MarkdownPanel the best approch is to add an option to enable a HTML-Sanitizer https://github.com/mganss/HtmlSanitizer before the HTML is send to the browser.

@mohzy83 mohzy83 added this to To do in MarkdownPanel Oct 16, 2020
@mohzy83 mohzy83 added this to the 0.6.0 milestone Oct 16, 2020
@mohzy83 mohzy83 removed this from the 0.6.0 milestone May 26, 2022
@mohzy83 mohzy83 moved this from To do to In progress in MarkdownPanel May 26, 2022
@mohzy83 mohzy83 moved this from In progress to Done in MarkdownPanel May 26, 2022
@mohzy83 mohzy83 moved this from Done to In progress in MarkdownPanel May 26, 2022
@mohzy83 mohzy83 moved this from In progress to To do in MarkdownPanel May 26, 2022
@mohzy83 mohzy83 removed this from To do in MarkdownPanel Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants