Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant queries for visitors #69

Open
Destroy666x opened this issue Apr 24, 2016 · 0 comments
Open

Redundant queries for visitors #69

Destroy666x opened this issue Apr 24, 2016 · 0 comments

Comments

@Destroy666x
Copy link

Destroy666x commented Apr 24, 2016

https://github.com/medbenji/MyProfile/blob/1bad85e6449347297450574968847f61c527453d/Upload/inc/plugins/myprofile/myprofilevisitors.class.php#L256 - get_user() in a loop, please don't ever do this, this is one of the worst practices in MyBB plugins. 15 latest visitors will generate 14 (15 - $mybb->user) additional queries for absolutely no reasonand you can set more than 15. JOINs exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant