Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MySQL8] groupby sort issue #190

Open
Jako opened this issue Mar 5, 2021 · 2 comments
Open

[MySQL8] groupby sort issue #190

Jako opened this issue Mar 5, 2021 · 2 comments

Comments

@Jako
Copy link
Collaborator

Jako commented Mar 5, 2021

The following code does not work anymore with MySQL 8:

$c->groupby($this->classKey . '.key', 'ASC');

According to @digitalpenguin it has to be reduced to:

$c->groupby($this->classKey . '.key');

@modxcms modxcms deleted a comment from JoshuaLuckers Mar 5, 2021
@muzzwood
Copy link

muzzwood commented Mar 8, 2021

Here's some info about it:
https://dev.mysql.com/doc/refman/8.0/en/upgrading-from-previous-series.html#upgrade-sql-changes

It now needs to be done with an ORDER BY clause.

@Jako
Copy link
Collaborator Author

Jako commented Feb 1, 2022

Yes, but xPDO has to handle this or throw/log some deprecated message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants