S3 media source - getObjectContents() not returning file content

[muzzwood]

Bug report

Summary

When using an S3 media source, and calling getObjectContents(), the file content is not returned.
This method should behave the same, whether it's filesystem, ftp, or S3 media source.

This might be because modS3MediaSource doesn't override modMediaSource::getObjectContents(). I'll try to look into this further soon.

Step to reproduce

Call getObjectContents() on an S3 media source. e.g.

$image = $this->source->getObjectContents($filePath);

Observed behavior

$image['content'] will be empty. If the same was done on a filesystem media source, the file content would exist.

Expected behavior

getObjectContents() should have the same behaviour regardless of the type of media source.

Environment

MODX 3.x, AWS S3