Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_JAVA_OPTIONS not removed when testing JREs #1171

Open
brawaru opened this issue May 4, 2024 · 0 comments
Open

_JAVA_OPTIONS not removed when testing JREs #1171

brawaru opened this issue May 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@brawaru
Copy link
Contributor

brawaru commented May 4, 2024

Describe the bug

In 0.7.0 Modrinth App started removing _JAVA_OPTIONS when launching the game. However, this variable is never removed when testing JREs in settings.

A cascade of “Could not create the Java Virtual Machine.” error messages.

Steps to reproduce

  1. Have _JAVA_OPTIONS environment variable defined to something like -Xmx0M, which apparently what it is set to for many users that have this variable set.
  2. Start Modrinth App.
  3. Go to ⚙️ Settings, scroll down to Java settings, and press ▶️ Test next to any Java location field.
  4. Observe the ‘Could not create the Java Virtual Machine.’ error.

Expected behavior

The evil _JAVA_OPTIONS environment variable is removed even when testing JREs.

System information

Universal, Modrinth App 0.7.1.

Additional context

ICOM-3367 (likely related).

@brawaru brawaru added the bug Something isn't working label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant