Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature-Request: Radio-Button Settings #202

Open
sebastian-marinescu opened this issue Feb 27, 2023 · 0 comments · Fixed by modxcms/revolution#16404 · May be fixed by #203
Open

Feature-Request: Radio-Button Settings #202

sebastian-marinescu opened this issue Feb 27, 2023 · 0 comments · Fixed by modxcms/revolution#16404 · May be fixed by #203

Comments

@sebastian-marinescu
Copy link
Contributor

I would like to be able to use radio-inputs for some settings.
In my opinion that would be useful for little "switch-settings" like for example "enable/disable custom scrollbar".
Also, as currently I am using dropdowns for these two options, this would save the user 1 click :-)

As Mark attempted in #176 with the multi-select checkboxes, I also ran into the same JS-issue.
Jako also stumbled upon the exact same issue modxcms/revolution#12177 some time ago.

I will prepare a PR for my own feature-request here, and I am attempting a PR on the actual issue in the MODX code.
This was referenced Feb 27, 2023
Merged
Open
@sebastian-marinescu sebastian-marinescu mentioned this issue Sep 4, 2023
Merged
opengeek added a commit to modxcms/revolution that referenced this issue Mar 22, 2024
@sebastian-marinescu @opengeek
Add guard-clause to clearDirty method (#16467)
3446d08 
### What does it do?
This makes sure the JS doesn't throw an error in the case that the
items-object is an array, just like in
#16404 for 3.x

### Why is it needed?
When using ExtJS to create components of the xtype: 'radiogroup' to be
used in CMPs inside a form,
this function gets called and tries to iterate over it's items array
with a method that doesn't exist.

This PR isn't changing the way forms or the clearDirty-method are
handled, it just assures no error is thrown when using
radiogroup-components.

### Related issue(s)/PR(s)
Resolves modmore/ClientConfig#202
Resolves modmore/ClientConfig#176
Resolves modmore/ClientConfig#143

---------

Co-authored-by: Jason Coward <jason@opengeek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@sebastian-marinescu