Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: expand benchmarking, try ASV #1989

Open
wpbonelli opened this issue Oct 18, 2023 · 0 comments
Open

feature: expand benchmarking, try ASV #1989

wpbonelli opened this issue Oct 18, 2023 · 0 comments

Comments

@wpbonelli
Copy link
Contributor

wpbonelli commented Oct 18, 2023

Is your feature request related to a problem? Please describe.

FloPy currently has a very small set of hand-rolled benchmarks, including

It might be worthwhile to a) benchmark a broader set of models/utils, and b) minimize ad hoc code needed to achieve this.

Describe the solution you'd like

Maybe benchmark load/write for all test models provided by a models API as proposed in #1872, as well as any widely used pre/post-processing utils. Could also try ASV — it has been adopted by other projects like numpy, shapely, and pywatershed.

Describe alternatives you've considered

We could just stick with pytest-benchmark and a bit of scripting instead of moving to ASV.

Additional context

This would help quantify performance improvements from the ongoing effort to use pandas for file IO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant