Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createTransformer contains duplicated code #321

Open
n9 opened this issue Aug 15, 2023 · 0 comments
Open

createTransformer contains duplicated code #321

n9 opened this issue Aug 15, 2023 · 0 comments

Comments

@n9
Copy link
Contributor

n9 commented Aug 15, 2023

Once here:

if (typeof arg2 === "object") {
onCleanup = arg2.onCleanup
keepAlive = arg2.keepAlive !== undefined ? arg2.keepAlive : false
debugNameGenerator = arg2.debugNameGenerator
} else if (typeof arg2 === "function") {
onCleanup = arg2
}

Another here:

if (typeof arg2 === "object") {
onCleanup = arg2.onCleanup
debugNameGenerator = arg2.debugNameGenerator
computedValueOptions = arg2
} else if (typeof arg2 === "function") {
onCleanup = arg2
} else {
onCleanup = undefined
debugNameGenerator = undefined
}

887d928 and 43805db might be incorrectly merged in 9fac6ae.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant