-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MNELAB (requires Qt 6) #82
Comments
An update on this one:
conda-forge/qt-main-feedstock#14 (comment) cc @cbrnr |
Yes, I saw that. 🤷♂️? It can be installed with pip, even in a conda env. I don't know why it is necessary to create conda packages when this is so much effort and when official binaries exist on PyPI. |
Because the installer ships much more than just Python packages |
Yeah, it's a pity the installer can't include pip packages. |
We can ship custom files, so we could include packages and install them via a post-install script, but it would require some fiddling. |
I think it would be worth a try. Maybe we can pip install in the post-install script? |
Yes. It's trivial to just run The problem with this is that it would require network / internet access. To avoid this, we'd need to bundle all PyPI dependencies, drop them into a separate folder, and run something like pip install --index-url /path/to/pypi-packages ... To ease things, we could simply bundle all "pip requirements" in a .zip file that we include in the installer. I'm still reluctant to do so as I believe the last time I tried to get PyQt6 working with my MNE conda environment, things got all sorts of "twisted-up" and I ran into some issues. I don't remember details though. In any case, I won't have time to look into this for at least a couple of weeks. |
Another approach: |
I don't think that pip installing those packages into a conda env will mess up anything – these are packages that only exist on PyPI. Last time I tried it worked, but I didn't test with the full environment used by the installer. But we just have to install from the installer and then pip install mnelab to know if there are any conflicts. Do we have any tests that we can run? Re internet access, we just have to bundle the source directory and then install via |
I think converting the wheels to conda packages and then using these with the installer will save us a lot of headaches. We just need someone to volunteer and create an exhaustive list of all dependencies of MNELAB that we currently cannot ship through conda-forge. I can then create conda packages for all of them and publish them to a custom channel. |
I can do that. The dependencies that are not available on conda-forge are |
Qt6 and PySide6 are now part of Once it's landed for all platforms, we can try to revive the MNELAB feedstock. |
Meanwhile, there is another problem that needs to be fixed first. Matplotlib doesn't work with the PySide6 backend, which MNELAB requires. They have already fixed it (matplotlib/matplotlib#24158), but we are waiting for a new release. Therefore, it's maybe best to wait for Matplotlib v3.6.2. |
As soon as we have Qt6 on
conda-forge
To keep track: conda-forge/qt-main-feedstock#14
The text was updated successfully, but these errors were encountered: