Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.7 #181

Open
adam2392 opened this issue Apr 21, 2024 · 15 comments
Open

Release v0.7 #181

adam2392 opened this issue Apr 21, 2024 · 15 comments

Comments

@adam2392
Copy link
Member

A lot of new features courtesy of @tsbinns.

We should aim to make a release. @tsbinns any interest in trying this out?

@tsbinns
Copy link
Collaborator

tsbinns commented May 7, 2024

@adam2392 Sorry for the delay, I was on holiday the last 2 weeks.

Yes, I would be very interested!

@adam2392
Copy link
Member Author

Would a v0.7 release of current code be better before merging in any GSoC changes?

linking: #183

I'm okay either way I suppose. cc: @drammock

@drammock
Copy link
Member

seems worth cutting a release now --- not necessarily because of impending GSoC changes, but because it's been ~5 months and there are some useful changes and bugfixes on main.

@tsbinns
Copy link
Collaborator

tsbinns commented May 28, 2024

@adam2392 I'm happy to help out if the offer still stands!

@adam2392
Copy link
Member Author

I don't have a walk-thru of how to do this exactly for mne-connectivity, but mne-bids has a writeup on how to do this. We just don't have a few of their steps tho.

https://github.com/mne-tools/mne-bids/wiki/How-to-make-a-release

Do you want to take a look and see if you can sketch out a sequence of steps that makes sense to you? Once you do it once, you'll have the exp to do it on any package :)

@adam2392
Copy link
Member Author

Let us know if you have questions

@tsbinns
Copy link
Collaborator

tsbinns commented May 29, 2024

Sounds good, I will try and get this done ASAP.

Though it might be worth waiting until #184 is merged since this has some nice efficiency improvements and is unrelated to the GSoC work. Thoughts?

@adam2392
Copy link
Member Author

Sounds good to me!

@tsbinns
Copy link
Collaborator

tsbinns commented May 30, 2024

WIP in #195

@tsbinns
Copy link
Collaborator

tsbinns commented May 31, 2024

@adam2392 One of the steps mentioned in the wiki is uploading to and checking install from test-pypi, but I don't have access. Do you need to do this before moving forward, or is it good enough that the installation in the circleci passes?

@drammock
Copy link
Member

drammock commented May 31, 2024

@adam2392 One of the steps mentioned in the wiki is uploading to and checking install from test-pypi, but I don't have access. Do you need to do this before moving forward, or is it good enough that the installation in the circleci passes?

Been a while since I've done this so I just tried and:

  • @adam2392 and @larsoner are the only maintainers on PyPI for mne_connectivity, so I can't help
  • the process is:
    • create an account on test.pypi.org (requires setting up 2FA)
    • generate an API token through account settings
    • run the twine upload... command and at the username prompt enter __token__ and at the password prompt enter the API token.

https://test.pypi.org/help/#apitoken

@larsoner
Copy link
Member

larsoner commented Jun 2, 2024

Rather than do all that I'd rather modernize with trusted artifact publishing on release

https://github.com/pypa/gh-action-pypi-publish?tab=readme-ov-file#usage

Can start from this and remove the username password stuff, then I can configure trusted publishing on PyPI:

https://github.com/mne-tools/mne-bids-pipeline/blob/main/.github/workflows/release.yml

@tsbinns if you want to learn how to do CI stuff feel free to open a PR to get the ball rolling. I can do the (pretty easy) config at the PyPI end of things. If you would rather focus on moving on to connectivity I can set up the action instead.

@adam2392
Copy link
Member Author

adam2392 commented Jun 2, 2024

Sorry for the delay. I had my wedding this past weekend so life was hectic.

But I agree that a GH action might make more sense and prevent this workflow issue in the future.

@larsoner
Copy link
Member

larsoner commented Jun 2, 2024

Sorry for the delay. I had my wedding this past weekend so life was hectic.

Awesome congrats! 🎉

Whenever convenient if you could make me an owner rather than maintainer I can do the trusted publishing stuff:

https://pypi.org/project/mne-connectivity/

You can also do it if you want (but please do make me an owner either way, it's not recommended to have a single owner of a project):

https://docs.pypi.org/trusted-publishers/adding-a-publisher/

@tsbinns
Copy link
Collaborator

tsbinns commented Jun 3, 2024

Congrats @adam2392!


@tsbinns if you want to learn how to do CI stuff feel free to open a PR to get the ball rolling. I can do the (pretty easy) config at the PyPI end of things. If you would rather focus on moving on to connectivity I can set up the action instead.

@larsoner Definitely, would be happy to try this. Regarding the existing publish_release.yml workflow, would the idea be to update this with some of the extra options in the MNE-BIDS workflow and split it into separate build and release jobs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants