Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for New Version Release on pip #1247

Open
bruAristimunha opened this issue May 9, 2024 · 13 comments
Open

Request for New Version Release on pip #1247

bruAristimunha opened this issue May 9, 2024 · 13 comments

Comments

@bruAristimunha
Copy link

Hello maintainers!

I've noticed that the latest changes in the source code have not yet been reflected in the pip package. These changes would be beneficial to braindecode and moabb.

We are having users with problems installing moabb/braindecode, and we cannot update mne_bids dependencies on moabb to resolve the issues because mne_bids is not compatible with the last version of mne.

Could you please release the new version of this package on pip? It seems that the current source code solves the problems.

Thank you for your time and consideration.

FYI @agramfort and @brunaafl

Copy link

welcome bot commented May 9, 2024

Hello! 👋 Thanks for opening your first issue here! ❤️ We will try to get back to you soon. 🚴🏽‍♂️

@hoechenberger
Copy link
Member

Hello,

could you please share the error you're seeing and which versions of MNE-Python and MNE-BIDS you're using?

@bruAristimunha
Copy link
Author

Hey @hoechenberger,

Sure!

The error was first reported in braindecode:
braindecode/braindecode#598

Then we discovered that it came from moabb:

NeuroTechX/moabb#586

The problem arises
because braindecode has no upper limit for the version of our dependencies, and moabb has.

@bruAristimunha
Copy link
Author

Report here too: NeuroTechX/moabb#598

@hoechenberger
Copy link
Member

hoechenberger commented May 9, 2024

I don't understand, at least in the last issue you posted, it's said that the problem is that MNE-BIDS 0.13 is not compatible with MNE-Python 1.7.

But the latest release of MNE-BIDS is 0.14. So I'm confused. Why don't you just install 0.14?

@hoechenberger
Copy link
Member

hoechenberger commented May 9, 2024

I checked the MOABB dependencies and they specify MNE <= 1.6 and MNE-BIDS 0.13

So you're destroying MOABB's dependency chain if you're installing MNE 1.7 with it

I assume you didn't realize that because they use poetry, which is non-standard-compliant in its dependency management

@bruAristimunha
Copy link
Author

Exactly!

@hoechenberger
Copy link
Member

Yeah but then there's really nothing the MNE-BIDS team can do to help you here ... or am I missing something?

@hoechenberger
Copy link
Member

Ah. Is it this EDF issue here that's causing the pain?

NeuroTechX/moabb#586 (comment)

@bruAristimunha
Copy link
Author

Exactly yes, I am copying @brunaalf if you need more details :)

@hoechenberger
Copy link
Member

hoechenberger commented May 9, 2024

@sappelhoff Would you have time to cut a new release anytime soon?

@sappelhoff
Copy link
Member

@hoechenberger yes, I should be able to do it within the next two weeks max.

Do you want to look into this before? #1245

something with the inspect module, I think.

@sappelhoff
Copy link
Member

I started migrating some issues over to the milestone for the release AFTER the impending on: https://github.com/mne-tools/mne-bids/milestone/17

However I think there are some issues we do need to solve before a release, like: #1250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants