Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider how we add original and auto-bads-processed data to the report #932

Open
hoechenberger opened this issue Apr 23, 2024 · 0 comments
Labels
enhancement New feature or request reports

Comments

@hoechenberger
Copy link
Member

hoechenberger commented Apr 23, 2024

Originally posted by @larsoner in #931 (comment)

Should we only set the pre-existing bads when generating the HTML repr for the original data, or should we set the pre-existing bads + all bads from the data quality checks?

To me the optimal thing to do here I think is to have two report entries:

  1. One which is the data as it comes originally from the dataset author with bads from the sidecar. It tells you what you start with before doing anything to it with the pipeline
  2. Another which is the data after our autobads (this section only needs to exist if we do some autobad detection). It tells you what the automated approaches did to the data

To me it's okay for brevity to have (1) have all the nice raw data plots, and have (2) maybe have less -- like just a list of channels removed or something? I think we're already kind of close to this organization:

image

But from that data quality plot it's not immediately clear which channels were added as bad, if any. Even just a HTML entry that lists the bads (when bad enabled) and flats (when flat enabled) would be a nice help

@hoechenberger hoechenberger added enhancement New feature or request reports labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reports
Projects
None yet
Development

No branches or pull requests

1 participant