Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't perform ICA cleaning on raw data by default when epochs are present #925

Open
hoechenberger opened this issue Apr 17, 2024 · 1 comment · May be fixed by #926
Open

Don't perform ICA cleaning on raw data by default when epochs are present #925

hoechenberger opened this issue Apr 17, 2024 · 1 comment · May be fixed by #926
Assignees
@hoechenberger
Labels
preprocessing

Comments

@hoechenberger
Copy link
Member

hoechenberger commented Apr 17, 2024 •
edited

I use ICA to clean my epochs. The apply_ica step now (I believe since #899?) cleans the raw data using ICA and adds the results to the report. I don't care for this; I only want to clean my epochs. The cleaned raws clutter my report. Could we change this behavior please?

cc @SophieHerbst

for now I've just commented out this section:

mne-bids-pipeline/mne_bids_pipeline/steps/preprocessing/_08a_apply_ica.py

Lines 275 to 298 in 79e19c1

# Raw
parallel, run_func = parallel_func(
apply_ica_raw, exec_params=config.exec_params
)
logs += parallel(
run_func(
cfg=get_config(
config=config,
subject=subject,
),
exec_params=config.exec_params,
subject=subject,
session=session,
run=run,
task=task,
)
for subject in get_subjects(config)
for session in get_sessions(config)
for run, task in get_runs_tasks(
config=config,
subject=subject,
session=session,
)
)

@hoechenberger hoechenberger changed the title Don't perform ICA cleaning on raw data by default Don't perform ICA cleaning on raw data by default when epochs are present Apr 17, 2024
@larsoner
Copy link
Member

Okay with me to add a config option to disable this for ICA and SSP

@hoechenberger hoechenberger self-assigned this Apr 18, 2024
hoechenberger added a commit to hoechenberger/mne-bids-pipeline that referenced this issue Apr 18, 2024
@hoechenberger
Don't perform ICA cleaning on raw data by default when epochs are pre…
8a76518 
…sent

Fixes mne-tools#925
@hoechenberger hoechenberger linked a pull request Apr 18, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoechenberger hoechenberger

Labels
preprocessing
Projects
None yet
Milestone
No milestone
2 participants
@hoechenberger @larsoner