Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider default of ch_types #912

Open
hoechenberger opened this issue Mar 29, 2024 · 0 comments
Open

Reconsider default of ch_types #912

hoechenberger opened this issue Mar 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@hoechenberger
Copy link
Member

Do you think we could change the default to None and simply use all available & supported channel types in this case? Otherwise, I don't know what a good default would look like.

Sure we could add this as an enhancement. At the moment it's not too bad since if users don't specify this they immediately get a clear error message saying they need to specify it (here I've removed ch_types from the ds004229 config):

$ pytest mne_bids_pipeline/ -k ds004229
...
E   ValueError: 1 validation error for user configuration from /home/larsoner/python/mne-bids-pipeline/mne_bids_pipeline/tests/configs/config_ds004229.py
E   ch_types
E     Value should have at least 1 item after validation, not 0 [type=too_short, input_value=[], input_type=list]
E       For further information visit https://errors.pydantic.dev/2.6/v/too_short

but ch_types = None meaning "autodetect and use all" seems like nicer behavior

Originally posted by @larsoner in #911 (comment)

@hoechenberger hoechenberger added the enhancement New feature or request label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant