Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Deduplicate filename decisions based on step choices #844

Open
larsoner opened this issue Feb 6, 2024 · 0 comments
Open

MAINT: Deduplicate filename decisions based on step choices #844

larsoner opened this issue Feb 6, 2024 · 0 comments

Comments

@larsoner
Copy link
Member

larsoner commented Feb 6, 2024

this is the third time I've seen the same inline "filt-or-regress" if-else. Makes me worry about forgetting to copy it where it's needed, when adding new code. Not sure if there is a sensible way to reduce that cognitive overhead / duplication that wouldn't feel over-engineered, though.

Originally posted by @drammock in #840 (comment)

There are other places where this happens, too, like in the filtering step where you need to triage based on whether or not SSS was used. It would be good if there were a standard way of handling this triaging. We have some helpers along these lines for picking "all raw data runs" (e.g., whether noise or rest needs to be processed in addition to task runs) so maybe we can do something similar that looks at cfg.spatial_filter, cfg.maxwell_filter etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant