-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add mf_bads option #760
Comments
The more I think about this the less it seems to make sense to allow Another way to think of it is that "runs" can really constitute a convenient way to split the data when saving into manageable chunks. In this sense the bads-per-run essentially create long, channel-specific Another option would be to concatenate the raws from all runs and come up with a single set of @hoechenberger okay to to treat it as a bugfix and use union of bads across runs rather than adding an option for it? |
Makes sense to me, but I wouldn't label it a bug fix but rather a behavior change |
One solution that should work for this would be something like:
where changing to
"union"
it will use the union of all bads across all data that will be maxwell filtered (runs + noise + rest). This actually in some sense is a safer option because the autobad only sometimes finds bad channels that it should find, so by combining across runs with a union is probably safest / most conservative.Originally posted by @larsoner in #759 (comment)
The text was updated successfully, but these errors were encountered: