Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives for PSR12 on PHP 7.4.2 #20

Open
aran112000 opened this issue Jan 30, 2020 · 0 comments
Open

False positives for PSR12 on PHP 7.4.2 #20

aran112000 opened this issue Jan 30, 2020 · 0 comments

Comments

@aran112000
Copy link

PrettyCI is returning errors from PHPCS when running PHPCS locally with the same .phpcs.xml file reports no errors so I don't believe this is a PHPCS issue.

The errors themselves reported aren't issues, and if changed, would actually introduce changes no longer compliant with PSR12.

Here are the results of my latest run showing the two issues:
https://github.com/aran112000/Form-Generator/runs/418127387

Specifically, these are the issues being flagged:

Expected at least 1 space after "?"; 0 found

protected ?string $value = null;

Expected at least 1 space before ":"; 0 found

public function getId(): string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant