Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move pause out of gbs code? #50

Closed
mmitch opened this issue Dec 25, 2020 · 1 comment
Closed

move pause out of gbs code? #50

mmitch opened this issue Dec 25, 2020 · 1 comment

Comments

@mmitch
Copy link
Owner

mmitch commented Dec 25, 2020

Should pause handling be delegated to the player code and be removed from gbs.c and gbhw.c?

If a player plays multiple GBS files in parallel (which will be possible with issue #41) and pauses one of then, then the paused gbs core will call nanosleep() when paused. This will affect the other GBS files as well.

Is there any need for the pause code to be in the core?
The player code can just stop calling gbs_step() and the core is effectively paused – no code needed in the core for that.

@mmitch
Copy link
Owner Author

mmitch commented Dec 29, 2020

I did this – it's merged to master.

@mmitch mmitch closed this as completed Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant