Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of internal package makes working on a fork difficutl #115

Open
ghost opened this issue Jan 30, 2019 · 1 comment
Open

Use of internal package makes working on a fork difficutl #115

ghost opened this issue Jan 30, 2019 · 1 comment

Comments

@ghost
Copy link

ghost commented Jan 30, 2019

detector.go imports an internal package:

"github.com/mmcdole/gofeed/internal/shared"

This makes it difficult to build main in a fork:

$ pwd
/home/lutz/go/src/github.com/lutzhorn/gofeed
$ go build
detector.go:7:2: use of internal package github.com/mmcdole/gofeed/internal/shared not allowed

I suggest to rename internal so that building in a fork is possible.

@mmcdole
Copy link
Owner

mmcdole commented Feb 2, 2019

I see how this could be a pain. I also don't feel especially strongly about the internal package, but I do believe I'm using it as intended, following Go conventions. Most of the items in internal are not meant to be exported or part of the public API for the library.

Here is an answer of how to possibly work on a fork, from another project that has a similar structure:

https://stackoverflow.com/questions/46860546/go-use-of-internal-package-not-allowed-when-running-a-go-project-forked-fro

I'll leave the issue open for now, to see if others have suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant