-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Steam games relaunches the frontend while launching game #442
Comments
Yes, unfortunately there's no way to detect when the game launched by Steam starts on closes -- frontends can only access Steam itself and ask it to launch the game. When Steam is already open this completes instantly, causing the issue you've seen. Sadly starting from a closed-Steam state won't entirely solve the problem, because Steam keeps running after a game closes, meaning you can't properly return to Pegasus either. These issues have been reported to Valve already (eg. |
That's a bummer since the Steam integration in Pegasus is extremely good except for this one issue Since it looks like Valve won't be fixing it on their end anytime soon I started looking into some other way of launching steam games reliably, there was a workaround posted in the the issue you referred to by Github user ejthill which I liked the sound of so I adapted it a little and made a very quick & simple proof-of-concept (Windows only) Basically what this launcher does is:
I would be willing to look into implementing something like this (ofcourse way more robust and cross-platform) directly into the frontend, or alternatively add some optional configuration option that lets the user configure what command is used to launch steam games if either of those sounds like a good idea to you? |
Yes I've seen these workarounds, but I had some issues:
I was also thinking about another approach, that we should check the process tree and see if Steam has any non-built-in child processes running. In theory that should be reliable, but it also have most of the same problems as above. Another idea, perhaps a Steam wrapper script could be set, which Pegasus would call instead of the Steam binary. One could set it to a script like the one you linked, but if that itself has bugs, there might be no way to return to the frontend. I'm also not sure if it'd work on macOS as things are launched differently there. Now these are only how I see things at the moment. However if you have a better idea or a working implementation I'd be always happy to take a look on it. |
After reading your reply and looking at it a little closer, it's safe to say I underestimated the complexity of the task 😅 But yes, the idea of letting the user set their own Steam wrapper script sounds like the best way forward, I'll try my hand at implementing it and submitting a PR and you can decide if it makes sense to merge or not 🙂 |
@PaddyCo apologies for the ping, but I'm hitting this issue now and was wondering if you had a binary built anywhere for your launcher? Cheers, thanks! |
As this is still a problem, how about that: If one starts a steam game, the video stops playing as long as no other game gets selected. This would easily work on all platforms. |
Yes, that might work for now. |
+1 to the @ToxicCrack idea. I finally got around to configuring Pegasus on my gaming VM, and this issue makes Stream integration effectively unusable, since Pegasus does a great job finding videos for everything! |
I fixed this issue by writing this launcher for steam. Instructions are in the zip file. You can add individual games and it will launch them, monitor them to allow Pegasus to go back to fullscreen when you are finished with the game. This works whether Steam is open or not. DJ. |
I also have a working Battle.net system too. I'll upload that when I have made the code look prettier. |
Hi DJ, Tried your launcher but received some errors even after using the correct version of the .net framework. In general, the issue remains - I can still hear the video for the Steam game playing in the background after launch. |
nice post like it |
Not sure if you're in the right place here, or an AI bot mass replying to tickets, but this has nothing to do with what you are describing. |
i just found a slight workaround, use the launch line in some metadata file: metal.bat: it just lauches the steam game and kill pegasus process, so you need to relauches pegasus manually when needed. |
Is there a fix for this on macOS? |
When I start a game from Steam through the frontend (default settings) it seems to trigger the exit game event while the game is still launching, causing some issues like the frontend running in the background (with videos still playing etc)
I think the reason is probably because when running steam.exe with the
steam://rungameid/XXXXX
parameter it simply returns exit code 0 once it has finished launching the game, which makes the frontend think the game has exited?Here are the relevant lines from my lastrun.log:
Same problem on two different computers (Both running Windows 10) with all games I've tested so far
The text was updated successfully, but these errors were encountered: