Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse Convolution? #3671

Closed
IgorWojas opened this issue Mar 29, 2024 · 6 comments
Closed

Reverse Convolution? #3671

IgorWojas opened this issue Mar 29, 2024 · 6 comments

Comments

@IgorWojas
Copy link

Hello

There is a vae example in the examples repo (https://github.com/mlpack/examples/blob/master/mnist_vae_cnn/mnist_vae_cnn.cpp)
that introduces reverse (transposed) convolution layer. The note in the code says that it is not implemented yet and leads to PR (#2777). In this PR the transposed_convolution.hpp is ticked away as if it was done, I can't find it anywhere so is it done?

Cheers

@IWNMWE
Copy link
Contributor

IWNMWE commented Mar 29, 2024

Hey @IgorWojas it seems that the Reparametrization and TransposedConvolution layers have not yet been adapted to the mlpack 4 layer style(It is present in the non adapted directory).

@IgorWojas
Copy link
Author

@IWNMWE Thanks for your reply. So this means its unusable in vanilla mlpack?

@IWNMWE
Copy link
Contributor

IWNMWE commented Apr 2, 2024

Yes , currently the unadapted layers require some changes to work with the current mlpack models. You can check out the adaptation of layers pull requests like #3445 to get an idea of what should be done to adapt these layers

@IgorWojas
Copy link
Author

That sums it up, thank you.

@rcurtin
Copy link
Member

rcurtin commented Apr 8, 2024

I don't think it would be hard to adapt TransposedConvolution; since the class is so related to Convolution, I think the changes in #2777 for the Convolution class could be pretty much taken as-is. There might be some minor input/output size issues to handle, but overall it should be straightforward. I would do it if I had the time, but at the moment I don't (sorry about that).

@IWNMWE
Copy link
Contributor

IWNMWE commented Apr 8, 2024

Hey, If no one is having a look at it I will look into its adaptation in a day or 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants