Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateStructure.py: use logical masks instead of iteration #87

Open
mlp6 opened this issue Sep 24, 2020 · 1 comment
Open

CreateStructure.py: use logical masks instead of iteration #87

mlp6 opened this issue Sep 24, 2020 · 1 comment
Assignees
@mlp6
Labels
Refactor / Technical Debt

Comments

@mlp6
Copy link
Owner

mlp6 commented Sep 24, 2020

A few structure types look for elements that fall within certain spatial criteria by iterating through all of the nodes. This would (probably) be much faster using some logical masks with numpy arrays instead of simple list operations.
@mlp6 mlp6 self-assigned this Sep 24, 2020
@mlp6
Copy link
Owner Author

mlp6 commented Sep 24, 2020

Need to add unit test for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlp6 mlp6

Labels
Refactor / Technical Debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mlp6