impulseResponse parameters

[mlp6]

from @ndanieley

"impulseResponse":
{
        "f0": 4000000.0,
        "phase": 0.0,
        "bw": 55.0,
        "wavetype": "gaussian"
},

I don't use any of those variables in my code, and as far as I can tell, you
don't use them in the matlab code. am I missing something?

[mlp6]

These parameters should be used by https://github.com/mlp6/fem/blob/master/field/defineImpResp.m. The parameters for impulseResponse were generated by the probe-specific Matlab calls in the old version (

fem/field/dynaField.m

Line 52 in 2275487

eval(sprintf('[Th,impulseResponse] = %s(FIELD_PARAMS);', FIELD_PARAMS.Transducer));

).

That workflow has been changed (improved) in your new workflow, but there may be some redundant parameters in the original JSON probe definition files. When wavetype is gaussian, then an idealized impulse is generated from f0 and bw; if experimental, then there is the expected time/voltage data used from hydrophone measurements to define the impulse response.

[ndanieley]

hmmm. I don't see any place where f0 is used; at least, grep can't find it. I'll just proceed on the assumption that I don't need to read that part of the probe file unless we find an error.