Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player name and coordinates overlap #452

Open
braoult opened this issue May 21, 2023 · 4 comments
Open

Player name and coordinates overlap #452

braoult opened this issue May 21, 2023 · 4 comments

Comments

@braoult
Copy link
Contributor

braoult commented May 21, 2023

White player name and coordinates overlap.

To reproduce (Configuration Builder):
Load Evergreen (No board), tick Show Coordinates and untick Coords Inner, to get coordinates outside the board.
We get:

image

Now, tick Headers, to add players name. We get :

image

Interesting part is that the buttons bar is moved down, as if the space used by player name was taken into account, and only name placement is actually wrong.

@mliebelt
Copy link
Owner

True. There is a correction done, but seems to be on the wrong element. I will check that, by producing an example that contains both elements (headers and coordinates out) to reproduce it. Should not be too complicated .... ( I hope :-) ).

@mliebelt
Copy link
Owner

I think I found the reason, does not want to do a release because of that.

@braoult
Copy link
Contributor Author

braoult commented May 22, 2023

Good ! and no problem for the release. For my information, is it a CSS-only problem, that I could try locally ?

@mliebelt
Copy link
Owner

No. There is some logic needed to set the CSS dependent on the configuration. So not so easy to fix in CSS only ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants