Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing file incorrect #42

Open
arvindnama opened this issue Nov 14, 2019 · 1 comment
Open

typing file incorrect #42

arvindnama opened this issue Nov 14, 2019 · 1 comment

Comments

@arvindnama
Copy link

Request intercept Interface looks like this::
request?(url: string, config: any): Promise<any[]> | any[];

Based on looking at the code , the library invoked intercept's request api with the exact same args as that of fetch so it should be
request?(input: RequestInfo, init?: RequestInit): Promise<any[]> | any[];

This will make the library usage better

@arvindnama
Copy link
Author

PS :: i can put in a PR for this , put i dont not have permission to push to remote branch . if you dont can i get permission to contribute to this Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant